-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New account setting to override Bulkrax's default split pattern #2380
New account setting to override Bulkrax's default split pattern #2380
Conversation
Add a new Account setting that will override Bulkrax's default multi-value split pattern. This effectively allows each tenant to have its own default split pattern This change relies on this Bulkrax commit to work: - samvera/bulkrax@9268bbb
Test Results 3 files ±0 3 suites ±0 18m 21s ⏱️ +39s For more details on these failures, see this check. Results for commit 0f27e3b. ± Comparison against base commit 8cf3a6f. This pull request removes 42 and adds 42 tests. Note that renamed tests count towards both.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
most of the time I feel like the default split pattern isn't as useful. its better to list the split pattern per field. And if we do that, then this wont help much. lets touch base tomorrow and see if this really solves the problem its pointed at
This PR has been superseded by: |
Ref:
Summary
Add a new Account setting that will override Bulkrax's default multi-value split pattern. This effectively allows each tenant to have its own default split pattern
This change relies on this Bulkrax commit to work:
Considerations
The default split pattern is only used when a field mapping specifies
split: true
:If a field declares a specific split pattern, it will be used for all tenants:
I think this is okay; in my experience, most installations use a single pattern for the vast majority of their fields. If I'm reading Bulkrax's
#process_parse
method correctly, that could be used in conjunction withsplit: false
to handle one-off fields with unique split patterns:That being said, if you can think of a better way to accomplish this, I'm open to suggestions
@samvera/hyku-code-reviewers